Prefer Flash Attn 2 instead of Fused Attn for THD dropout on Blackwell - #3313
Prefer Flash Attn 2 instead of Fused Attn for THD dropout on Blackwell#3313bzantium wants to merge 2 commits into
Conversation
Greptile SummaryThis PR changes Blackwell backend selection so THD training with dropout prefers FlashAttention 2 over the slower FusedAttention path.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported advisory-ordering issue is resolved by placing the preference and its debug message after backend availability is finalized. Important Files Changed
Reviews (3): Last reviewed commit: "Keep the THD dropout condition under the..." | Re-trigger Greptile |
|
Thanks for the detailed reporting in #3312! I agree that this affects users' performance and without warning, but I don't think it's TE's responsibility to cache these default-value issues coming from Megatron. Given that dropout is going out of fashion, Megatron can probably change their default to 0 but in a gradual deprecation code cycle. This way, it wouldn't incorrectly and silently call FlashAttention for dropout either. With cuDNN, we can check with them to see if they can speed up the dropout implementation on Blackwell for THD, to match FlashAttention's performance. For now, we can disable FusedAttention for THD + dropout + Blackwell, and allow users to use FlashAttention instead. @KshitijLakhani, could you please lead the discussion with cuDNN, file a bug if necessary, and guide @bzantium to disable FusedAttention in this PR? Thanks! |
@bzantium thanks for reporting this. Please set NVTE_FUSED_ATTN=0 NVTE_FLASH_ATTN=1 (hopefully this unblocks you temporarily)
For THD with dropout 0.1, switching to FA2 reduced time from 4.407 ms to approximately 0.728 ms, about a 6.1× speedup.
To verify that FA2 is selected, temporarily use: The log should report something like this: NOTE: I am suggesting NVTE_UNFUSED_ATTN=0 only as a validation guard to prevent silent fallback. |
There was a problem hiding this comment.
Replace the existing Hopper+ FusedAttention preference block with the following narrow selection rule. This safely prefers FA2 only when it is confirmed installed, enabled, and eligible. Otherwise, FusedAttention remains enabled.
# Prefer FA2 for THD training with dropout on SM100/103, where FusedAttention has a known
# performance issue. At this point use_flash_attention_2 confirms a usable installation.
if (
is_training
and qkv_format == "thd"
and attention_dropout != 0.0
and device_compute_capability in ((10, 0), (10, 3))
and use_flash_attention_2
and use_fused_attention
):
logger.debug(
"Disabling FusedAttention to give FlashAttention 2 preference for THD with dropout on SM100/103"
)
use_fused_attention = False
fused_attention_backend = None
# Select FusedAttention for performance in all other Hopper+ configurations.
elif use_flash_attention and use_fused_attention and device_compute_capability >= (9, 0):
logger.debug(
"Disabling FlashAttention to give FusedAttention preference on Hopper+ "
"for performance reasons"
)
use_flash_attention = False
Please place this after unavailable FlashAttention installations have been filtered and use_flash_attention_2 has been finalized. This placement is important because it ensures that FusedAttention is disabled only when FA2 is actually usable.
|
@bzantium Here's a quick update: I discussed with the cuDNN team and it's a known shortcoming. The issue is not unified v/s composite but it is the slow dropout kernels used for this very specific combination being discussed here. The fact that the slow dropout kernels are being triggered in a composite setup worsens the timing. cuDNN does not have this on their roadmap for the foreseeable future as it is low priority and the suggested "fix" is for TE users to use FA2 instead if performance is of importance. If you'd like to contribute to TE, which we highly encourage, I've reviewed your PR and added suggested changes. Please review these changes and commit them. Once you've done this I can help you launch CI on this PR and review/approve the PR to have it merged in to main. On the contrary, if you'd rather have me add in these changes, I'm happy to do so in a separate PR. Let me know. Notes:
|
|
Lastly, here's a small mock up test I came up with using my agent. I just asked it to write a test to confirm the backend choice. This is juts a guidance but it does the trick. Feel free to be creative :) |
|
@bzantium just circling back to check in if you were able to try the suggested changes ? |
cuDNN's dropout kernels for THD attention are much slower than FlashAttention 2's on SM100/103, and the cuDNN team confirmed a fix is not on their roadmap. The generic Hopper+ rule prefers FusedAttention, so this combination silently took the slow path with nothing reporting it. Prefer FA2 for THD training with dropout on SM100/103 when FA2 is confirmed usable, and leave every other configuration on the existing rule. The earlier advisory is dropped: it ran before backend selection was final and could name FusedAttention when a later filter selected something else. Signed-off-by: Minho Ryu <ryumin93@gmail.com>
e621034 to
54f463b
Compare
|
@KshitijLakhani thanks for chasing this with the cuDNN team, and sorry for the slow reply. Took both suggestions in 54f463b. The advisory is gone, and the FA2 preference now sits after For the test I stayed close to your mock-up but added Ran it on an SM103 box with both backends available: FusedAttention ( |
bvolpato
left a comment
There was a problem hiding this comment.
Other than these two questions, this looks good to me. Preference is narrowly scoped and runs after backend eligibility is finalized, and the test covers the intended selection.
| # Prefer FA2 for THD training with dropout on SM100/103, where FusedAttention has a known | ||
| # performance issue. At this point use_flash_attention_2 confirms a usable installation. | ||
| if ( | ||
| is_training |
There was a problem hiding this comment.
Could we simplify this condition or add a targeted too-many-boolean-expressions disable? The repo’s pinned Pylint reports R0916 here (6/5), so qa/L0_pytorch_lint/test.sh should fail once full CI runs. Is that a concern?
There was a problem hiding this comment.
Yes, real concern. Reproduced it with the repo's pylintrc and pinned pylint 3.3.1: R0916: Too many boolean expressions in if statement (6/5).
Split the condition rather than disabling the check, since the hardware and workload half wants a name anyway:
is_slow_fused_thd_dropout = (
is_training
and qkv_format == "thd"
and attention_dropout != 0.0
and device_compute_capability in ((10, 0), (10, 3))
)
if is_slow_fused_thd_dropout and use_flash_attention_2 and use_fused_attention:File is back to 10.00/10 in a310413.
| the roadmap, so the choice is made here rather than left to the generic Hopper+ rule | ||
| that prefers FusedAttention. | ||
| """ | ||
| monkeypatch.setenv("NVTE_FLASH_ATTN", "1") |
There was a problem hiding this comment.
Should we also set NVTE_FLASH_ATTN_V2=1 here? get_attention_backend reads that flag independently, so a run inheriting NVTE_FLASH_ATTN_V2=0 reaches this test and fails available_backends[0] even though FA2 is intentionally disabled. Is that a concern for test isolation?
There was a problem hiding this comment.
Good catch, NVTE_FLASH_ATTN_V2 is read separately at utils.py:525, so inheriting NVTE_FLASH_ATTN_V2=0 would fail the availability assertion rather than skip. Pinned it in a310413 with a note on why.
The six-term condition tripped R0916 (6/5), which the repo does not disable, so qa/L0_pytorch_lint would have failed. Naming the hardware and workload half also says what the condition is for. Pin NVTE_FLASH_ATTN_V2 in the test as well. get_attention_backend reads it apart from NVTE_FLASH_ATTN, so an environment that disables FA2 on purpose would fail the availability assertion instead of skipping. Signed-off-by: Minho Ryu <ryumin93@gmail.com>
What does this PR do?
Adds a
logger.debugline for the case whereqkv_format="thd"andattention_dropout > 0, which is served by the composite cuDNN engine rather than the unified one.Related to #3312.
Why
fused_attn_f16_arbitrary_seqlen.cualready notes that dropout and stats generation cannot be combined on the unified engine, so a thd request with dropout is routed to the composite engine, which does not supportcu_seqlens:The routing is correct, but it is expensive and silent. Forward + backward through one
DotProductAttention, 4096 tokens, 16 heads,head_dim128, bf16, median of 50 iterations after 20 warmup:thdsbhdsbhdA profile attributes it to
cudnn::fusion::gen_dropout_mask_4bitand its transpose variant, which together take 43% of CUDA time in an 8-layer training step on B300.Backend selection already logs every case where a backend is disabled, so a user reading
NVTE_DEBUG_LEVEL=2output sees why a backend was not chosen. This case is different: the backend is chosen and quietly costs several times more. Most configurations setattention_dropoutto 0 and never see it, but Megatron-Core'sTransformerConfigdefaults it to 0.1, so a packed run that does not set it explicitly inherits the slow path with nothing in the log to suggest it.This does not change behaviour — it only makes the situation visible. The underlying fix belongs to the cuDNN frontend restriction quoted above.
Testing
black(repo settings) andpylint --rcfile=pylintrcclean on the changed file. No behavioural change, so no new tests; the line appears in existingNVTE_DEBUG_LEVEL=2output when the condition holds.